Make DataDictionaryTest external DTD error assertion locale-independent#1091
Merged
Conversation
chrjohn
changed the title
DataDictionaryTest external DTD error assertion locale-independent
Member
|
Thanks for the PR, @wilson-zh 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #443.
This test fails on systems where the XML parser returns a localized (non-English) error message.
The test now forces Locale.US and restores the original locale afterward, ensuring consistent behavior across environments.
Note: I could not reproduce the localized message in
CH-ZHon my current setup, but the fix is test-only, low-risk, and directly addresses the issue described.